Okay, i just tested this MOD, and i must say, great work, handyman!
Very niceley done!
I'll give you some feedback, hope you don't mind
Install file:You should have the stuff indented fully
(picky me):
- Code: Select all
$ajax = false;
if ($user->data['user_id'] != ANONYMOUS && $user->data['user_type'] != USER_INACTIVE && $user->data['user_type'] != USER_IGNORE)
{
$s_action = 'javascript:void(0);';
$ajax = ' onsubmit="get(this);" name="postform"';
}
Could be:
- Code: Select all
$ajax = false;
if ($user->data['user_id'] != ANONYMOUS && $user->data['user_type'] != USER_INACTIVE && $user->data['user_type'] != USER_IGNORE)
{
$s_action = 'javascript:void(0);';
$ajax = ' onsubmit="get(this);" name="postform"';
}
Same goes for the edit after that
I don't think this is allowed, i suggest you have separate actions for sub- and prosilver.
- Code: Select all
Open: styles/*/template/viewtopic_body.html
For the edit in styles/*/template/posting_qr_body.html i suggest you use inline actions.
Then, when submitting a new post, i get this:
- Code: Select all
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in C:\Program Files\server\apache\htdocs\phpbb\phpBB3\quickposting.php on line 115
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in C:\Program Files\server\apache\htdocs\phpbb\phpBB3\quickposting.php on line 115
This is because my php.ini is a little strictly configured (may also just be PHP5, i don't know). Well, all i can say is that variables should not be passed by reference when calling a function:
- Code: Select all
submit_post('reply', $subject, $user->data['username'], $topicrow['topic_type'], &$poll, &$data, $update_message = true);
Should be:
- Code: Select all
submit_post('reply', $subject, $user->data['username'], $topicrow['topic_type'], $poll, $data, $update_message = true);
Another wierd thing that i noticed is that you didn't handle multiple pages. I went to a topic with 2 pages, added a quick reply on the first page. It added the reply on the first page (without reloading). So you need to add some kind of check, to see if the user is on the last page, and if the reply goes onto a new page, and if that is the case, redirect them with javascript (or PHP, if you find some great way to do it
).
And in quickposting.php, there's this:
- Code: Select all
if (!$auth->acl_get('f_reply', $forum_id) || !$user->data['is_registered'])
{
if ($user->data['is_registered'])
{
trigger_error('USER_CANNOT_REPLY');
}
login_box('', $user->lang['LOGIN_EXPLAIN_REPLY']);
}
if ($config['flood_interval'] && !$auth->acl_get('f_ignoreflood', $forum_id))
{
// Flood check
$last_post_time = $user->data['user_lastpost_time'];
if (($current_time - $last_post_time) < intval($config['flood_interval']))
{
trigger_error('FLOOD_ERROR');
}
}
Which can result in:
Okay, i think that's all. Great work! Other than what i meantioned, the MOD works perfectly
Great work!
by 
