[MOD] Search Engine Friendly (SEO) URLs 1.0.0 RC4

[fantasticboy301 Hieu]

there needs to be a comma after "phpbb_posts p"

Handy man, Can you tell me how to fix it. How can i add a comma?
Give me instruction. Thanks

[topdown]

Try this,
OPEN includes/functions_seo.php should be about line 158

FIND

Code: Select all

            FROM ' . POSTS_TABLE . ' p

REPLACE WITH

Code: Select all

            FROM ' . POSTS_TABLE . ' p,

[cyba]

I have an issue with the latest phpbb update.

On all styles i have this issue.

The pageheader Link in topics and thread view is broken with a '-' at the end of the URL.
Also, the "Mark Forums Read" is broken in the latest version, it shows confirmation screen but nothing happens.
My cookie configs are correct and i've tried a few fixes... what can you tell me?

[cyba]

Discovered the issues and made these fixes.

Don't fully understand why it decides to add an extra '-' at the end of the link, but hey, heres how to get rid of it.
Open includes/functions_seo.php

Find:

Code: Select all

return $url . (($append_url) ? $url_delim . $append_url . $amp_delim : $url_delim) . $params . ((!$session_id) ? '' : $amp_delim . 'sid=' . $session_id);

Replace With:

Code: Select all

return trim($url . (($append_url) ? $url_delim . $append_url . $amp_delim : $url_delim) . $params . ((!$session_id) ? '' : $amp_delim . 'sid=' . $session_id), '-');

A hash has been added (for security) when marking topics read, here is a fix for the "mark topics read bug":

Open viewforum.php:

Find:

Code: Select all

'U_MARK_TOPICS'      => ($user->data['is_registered'] || $config['load_anon_lastread']) ? format_url($forum_name, "f$forum_id", 0, 'mark=topics') : '',

Replace With:

Code: Select all

'U_MARK_TOPICS'      => ($user->data['is_registered'] || $config['load_anon_lastread']) ? format_url($forum_name, "f$forum_id", 0, 'mark=topics&hash=' . generate_link_hash('global')) : '',

Problem solved!
The official developers of the mod may not be happy with these fixes, so please check back to see what they say.

[idontwantausername]

just a quick bug report

on the view topic page, if you click a page number, (bottom right corner in the topic name field), it will take you to the SEO URL, but instead of having .html on the end it has .php

[lks45]

[b]BUG REPORT[/b]

http://img300.imageshack.us/img300/2860 ... ortlf6.jpg



What is the solution to have all links in dot html (not php!!)

[phreakwars Eric]

Discovered the issues and made these fixes.

Don't fully understand why it decides to add an extra '-' at the end of the link, but hey, heres how to get rid of it.
Open includes/functions_seo.php

Find:

Code: Select all

return $url . (($append_url) ? $url_delim . $append_url . $amp_delim : $url_delim) . $params . ((!$session_id) ? '' : $amp_delim . 'sid=' . $session_id);

Replace With:

Code: Select all

return trim($url . (($append_url) ? $url_delim . $append_url . $amp_delim : $url_delim) . $params . ((!$session_id) ? '' : $amp_delim . 'sid=' . $session_id), '-');

A hash has been added (for security) when marking topics read, here is a fix for the "mark topics read bug":

Open viewforum.php:

Find:

Code: Select all

'U_MARK_TOPICS'      => ($user->data['is_registered'] || $config['load_anon_lastread']) ? format_url($forum_name, "f$forum_id", 0, 'mark=topics') : '',

Replace With:

Code: Select all

'U_MARK_TOPICS'      => ($user->data['is_registered'] || $config['load_anon_lastread']) ? format_url($forum_name, "f$forum_id", 0, 'mark=topics&hash=' . generate_link_hash('global')) : '',

Problem solved!
The official developers of the mod may not be happy with these fixes, so please check back to see what they say.

I was running into the same 2 problems and that fixed it, but I did notice another bug when I click the "MARK FORUMS READ" link still.

[phreakwars Eric]

One more glitch I notice is when you go to bump a topic, I get the following

Followed by a 404 not found page.

Otherwise, I love this MOD.

Edit: I feel kinda dumb here, I just checked this MOD topic on PhPBB's website and found answers I was looking for. Keep up the good work
.
.

[rosdi Rosdi Bin Ahmad]

Hi all,

1. In my forum: http://www.bettasocietymalaysia.com.my, the footer still displaying not in center:

[
SEO MOD © 2007 StarTrekGuide ]

How to overcome it.

2. If we click/view the topic from:
- View unanswered posts: http://www.bettasocietymalaysia.com.my/ ... unanswered
- View active topics: http://www.bettasocietymalaysia.com.my/ ... ive_topics
- View new posts: http://www.bettasocietymalaysia.com.my/ ... d=newposts
- View your posts: http://www.bettasocietymalaysia.com.my/ ... =egosearch

It will display in php, not html. Is it normal?

Thanks.

[rosdi Rosdi Bin Ahmad]

Sorry Sir,

Another thing is about the topic reply email notification. Will it give to html address when somebody reply in the topic after the mod been taken place?

Clicking the php address will give 404 error.

This is an example of the address link in the email: http://www.bettasocietymalaysia.com.my/ ... 01&e=36301

When you click it, it become: http://www.bettasocietymalaysia.com.my/ ... 301#p36301 - giving 404 error.

Where it should be: http://www.bettasocietymalaysia.com.my/ ... tml#p36301 for working address.

Thanks.