[Add-on] STG Custom Smiley Pack

[CityState]

Do I just enter this code into the SQL query to correct it in sql?

Code: Select all

SELECT smiley_url, MIN(emotion) as emotion, MIN(code) AS code, smiley_width, smiley_height FROM phpbb_smilies GROUP BY smiley_url, smiley_width, smiley_height ORDER BY MIN(smiley_order) LIMIT 50


This is the error shown above.

[Sniper_E]

Why are you asking me? I don't know.

j/k, I just installed a fresh 3.0.7-PL version and I'll test this out to see if I get what you get.

Edit: Nope, I did just as you did and it installed fine.
Clicking 'View more smilies' gave me the popup of smilies with two pages of smilies to choose from.
I used the download from this post: viewtopic.php?p=25598#p25598

I would have no idea why you are getting that error. Maybe someone will drop by that might know.

And I didn't like the looks of that popup, so I added a little bg2 to it and put the "Smilies" inside of it.
I like to tweak pages.

Code: Select all

<!-- INCLUDE simple_header.html -->

<script type="text/javascript">
// <![CDATA[
   var form_name = 'postform';
   var text_name = 'message';
// ]]>
</script>
<script type="text/javascript" src="{T_TEMPLATE_PATH}/editor.js"></script>

<div class="panel bg2">
   <div class="inner"><span class="corners-top"><span></span></span>
      <h2>{L_SMILIES}</h2>
      <!-- BEGIN smiley -->
         <a href="#" onclick="initInsertions(); insert_text('{smiley.A_SMILEY_CODE}', true, true); return false;"><img src="{smiley.SMILEY_IMG}" width="{smiley.SMILEY_WIDTH}" height="{smiley.SMILEY_HEIGHT}" alt="{smiley.SMILEY_CODE}" title="{smiley.SMILEY_DESC}" /></a>
      <!-- END smiley   -->
   <span class="corners-bottom"><span></span></span></div>
</div>

<div>{PAGINATION}</div>
<a  href="#" onclick="window.close(); return false;">{L_CLOSE_WINDOW}</a>

<!-- INCLUDE simple_footer.html -->

[CityState]

I know... I wish I knew what was wrong.

I tried re-installing the pack after deleting every smiley, tried getting the smiley folder from the orignal 3.0.7 folder and still the error code.

[Sniper_E]

Recently, I've created a new forum using 3.0.7. The smiley pak was then uploaded to it, deleting the old smiles.

When you say you deleted the old smilies, do you mean that when installing the new smilie.pak you selected the install to remove them?
Or did you delete the old smilies manually? I don't know why I ask, you've done this a few time successfully on other versions.
These old smilies were deleted in the ACP, by the smilie pak installer, right?

[CityState]

I know what you mean...

I deleted them first by FTP. Hmm.. Then I think I placed them back coz I made a back up anyway. Then once they were back, I deleted them via the acp install method.

You think the error is SQL based? it says that the limit could be the prob. I made a few sql-related mods before I identified the prob. But all those mods were simply to query sql lines. Didn't change anything.

[Sniper_E]

Yea, you are not suppose to delete them manually. The install new smilies is suppose to take the old ones out.
I just looked in the original files in the images/smilies/ directory and it does not have a smilie.pak with them.

I'm drawing a blank on how to get them back in there or how to fix your problem.
Try creating a new smilie.pak file to reinstall them and start over maybe. Dunno.... Good luck!

[CityState]

Ok... Let me find an original smiley pack. Then I'll upload it.

Thanks!

----------------

update: Nope that didn't solve it either. It says its an sql prob. Should I enter the sql error in the querry then?

[CityState]

Yeah baby, it's fixed!! It's a legit 3.0.7 pl1 bug...

Reference: Link

Summary of the fix as shown in the Spoiler below -

Spoiler:

Find: in includes/functions_posting.php

Code: Select all

   if ($mode == 'window')
   {
      $sql = 'SELECT smiley_url, MIN(emotion) as emotion, MIN(code) AS code, smiley_width, smiley_height
         FROM ' . SMILIES_TABLE . '
         GROUP BY smiley_url, smiley_width, smiley_height
         ORDER BY MIN(smiley_order)';
      $result = $db->sql_query_limit($sql, $config['smilies_per_page'], $start, 3600);
   }


Replace with:

Code: Select all

       $sql = 'SELECT smiley_url, MIN(emotion) as emotion, MIN(code) AS code, smiley_width, smiley_height, MIN(smiley_order) AS min_smiley_order           FROM ' . SMILIES_TABLE . '           GROUP BY smiley_url, smiley_width, smiley_height           ORDER BY min_smiley_order';


[Honor]

I am working from a mac. I can open the Tar file (the file with all the smileys), but my computer refuses to read the first download (the .pak.zip). Is there something I'm missing?



EDIT:
Nevermind. It works