[DEV] phpBBmobile Device Browser Style

[Agitjob]

Sorry, I didn't make it clear. I saw your previous post but it's kinda a quick fix and hard coding the URL of the image into the html file. Is there anyway we can control the size dynamically? Oh, can i define the size in the ACP instead??
Thanks for your patience ^^

EDIT:
I just changed the setting of banner from ACP. Could you please check if it's still stretching your screen?

[Sniper_E]

Yes Agitjob, that did the trick. My screen was not stretched out in the normal view or sideways.
Your banner image stretched out bigger in my side view the way it should.

Altho... By stating the width and the height of an image, the image was not proportional to it's size.
That is why I only stated the width in my codes. The height will adjust proportional to the image size.
But it still looked much better and didn't stretch my screen out, that was more important.

Why would you be reluctant to hard code that image in your template?
If you want it right, that's the way to go. I don't think you can only state the width in the ACP... Or can you?

Now, what else can we do? Did that captcha work with those new templates? Any changes needed there?

[Agitjob]

Yes Agitjob, that did the trick. My screen was not stretched out in the normal view or sideways.
Your banner image stretched out bigger in my side view the way it should.

Altho... By stating the width and the height of an image, the image was not proportional to it's size.
That is why I only stated the width in my codes. The height will adjust proportional to the image size.
But it still looked much better and didn't stretch my screen out, that was more important.

Why would you be reluctant to hard code that image in your template?
If you want it right, that's the way to go. I don't think you can only state the width in the ACP... Or can you?

Now, what else can we do? Did that captcha work with those new templates? Any changes needed there?

The reason that I don't want to hard code is, i'm not the only admin of my forum. There are 2 others, and i really don't want them to mess with the code whenever they want to change banner. Plus, it's kinda troublesome if they sometimes make a typo when typing the link which would make the banner totally disappear. What i did before asking you to test was I went to imageset of the mobile theme, and edit the banner with defined width and height. Agree that it's not optimized and can't be proportional, but that's the only way i can think of now at the top of my head.

Sorry, i still haven't had chance to reach my proper laptop to try the captcha. I'll let you know as soon as I have something ^^ Thanks.

I still need your suggestion on the Youtube bbcode....

[Agitjob]

YAY!! The Captcha works as a charm now I tried Q&A and it also works. Thanks a lot, Sniper.

Now the only thing left is the Youtube video bbcode. notice the same problem if i have an image or quote box embedded in the post. It would stretch the screen also. Anyone encounters the same problem as me??

[cisco007]

is anybody else having this problem but me, when trying to run STK?

Code: Select all

Fatal error: Cannot redeclare mobile_device_detect() (previously declared in /homepages/XX/XX/htdocs/XX/includes/mobile_device_detect.php:68) in /homepages/XX/XX/htdocs/XX/includes/mobile_device_detect.php on line 269

not really sure how to fix that!

[Agitjob]

It says you have duplicated declaration of the 'mobile_device_detect()' function at line 68 and line 269 of that php file. You can double check if they're identical and just delete one of them. That should work, I hope.

[cisco007]

i am thinking it's something with the STK, not the file itself. It's fine everywhere else.

[Hippie459MN]

i am thinking it's something with the STK, not the file itself. It's fine everywhere else.

I know the STK was just updated a few days ago over at phpBB. Maybe you need to install the newest version. I would get weird errors like that when I had an old STK version installed.

[cisco007]

i already have the latest version. because i helped translate it to spanish so don't know what it could be.
in my session.php file i temporarly changed this:

Code: Select all

       $this->data['is_mobile'] = false;
       include($phpbb_root_path . 'includes/mobile_device_detect.' . $phpEx);

to this:

Code: Select all

       $this->data['is_mobile'] = false;
       include_once($phpbb_root_path . 'includes/mobile_device_detect.' . $phpEx);

that seems to have fixed the problem and the style still shows for and posts as mobile! what do you think Snipe!?

[Sniper_E]

Yes Cisco... that line is suppose to be include_once from what I remember.
The first version had only include in the line and Topdown had to fix that.
I thought we fixed that in the .zip install. I'll have to check that. Thanks!

Edit: I just checked the .zip install file... It is written include_one in the install file.

Code: Select all

      // phpBB_mobile_detect - Mobile Stlye Redirect MOD
         $this->data['is_mobile'] = false;
         include_once($phpbb_root_path . 'includes/mods/mobile_device_detect.' . $phpEx);
         $this->data['is_mobile'] = mobile_device_detect();

         if ($this->data['is_mobile'] == true)
         {
            $style = 3;
            $this->data['is_mobile'] = true;
         }
      // phpBB_mobile_detect End