I took your file and loaded to my testboard and everything works just fine so I think your problem is in the custom profile filed itself. Go back over the instrctions portion on how to set up the profile fields in your ACP. Make sure you have configured them to show on Viewtopic & profile. Make absolutely sure that you are calling your profile filed names correctly. Also make sure you have purged your cache after making any template edits.
Hope this helps. If you are still having problems please let me know.
BTW those END IF statements are fine how you have them. I didn't realize at first that you were using prosilver.
Thanks, I appreiciate the comment. I think I do alright with the template stuff, it's the php that kills me.