Redirects for Login page.

[AJ Quick AJ Quick]

I don't know how safe this is.. but I wanted to be able to do redirects via URL when logging in. AKA: /forums/ucp.php?mode=login&redirect=(PAGE)

Here is the code:

Code: Select all

   case 'login':
      if ($user->data['is_registered'])
      {
         redirect(append_sid("{$phpbb_root_path}index.$phpEx"));
      }
      
      $redirect   = request_var('redirect', '');   
      
      if($redirect)
      {
         login_box($redirect);
      }else{
         login_box("index.$phpEx");
      }
   
   break;

Critiques? Feedback? etc.

[Handyman]

Here is the code you want to use
Note: you change the user->lang['LOGIN_EXPLAIN stuff to whatever you want it to say.
With that language, when you get transferred to the login page, it says: you must be logged in to view the memberlist.

Code: Select all

<?php
if ($user->data['user_id'] == ANONYMOUS)
{
    login_box('', ((isset($user->lang['LOGIN_EXPLAIN_' . strtoupper($mode)])) ? $user->lang['LOGIN_EXPLAIN_' . strtoupper($mode)] : $user->lang['LOGIN_EXPLAIN_MEMBERLIST']));
}


[AJ Quick AJ Quick]

That code doesn't make sense for anything really important.. except for forcing a login box.

I use 'login_box' whenever I want to force someone to be logged in on any part of my site (even on non-forum pages). There are times when I will ask a user to login and want them to be able to return back to the same page.. but not force a login box. Thats what the code does.. it allows redirects through the URL.

It is possible to redirect to any page unfortunately.. so you could redirect to Google if wanted (so there would be security risks?) but its not like it transfers any data when doing that.

[Waleed]

It is possible to redirect to any page unfortunately.. so you could redirect to Google if wanted (so there would be security risks?) but its not like it transfers any data when doing that.

I don't think there would be any security risks with redirecting to any other page from the login box, as the loging box first logs you in, and then redirects you...

[tonydavis6]

Where do you put this code?

[Highway of Life]

Depends on where you want it.

If you want to force the user to have to login when visiting your forum, but it just after the session is started on the index.php page.

[beaver86]

Could someone write a full code example for that login thing?!

P.S.:Suppose that i want it to be on my index.php page and the forum is located under the "forum" dir.

Thanks

[xceler8shun]

ive just had this approved over at phpbb.com

http://startrekguide.com/mods/index.php ... ail&id=144

may help you out.