get rank title

[jwxie]

I tried to get the rank title using get method, and user->data method
but when i look into the code more carefully, i didn't get the right row, it only generated the number rank, like 1, 2, 3, 4

i am trying to pull it out and display it on the index
anyone can help me out?

[Erik Frèrejean]

The value that is stored in the $user->data['user_rank'] variable is the id of the rank. You can use this to fetch the actual rank from the RANKS_TABLE

Code: Select all

$sql = 'SELECT *
   FROM ' . RANKS_TABLE . '
   WHERE rank_id = ' . $user->data['user_rank']; 

[jwxie]

hey thanks. this is my code now
is it good to you guys?
i can display it, just asking :]

Code: Select all

$sql = 'SELECT rank_title
   FROM ' . RANKS_TABLE . '
   WHERE rank_id = ' . $user->data['user_rank'];
$result = $db->sql_query($sql);
$rank_title = $db->sql_fetchfield('rank_title');
$db->sql_freeresult($result);

[Erik Frèrejean]

Well if you can print $rank_title and it displays whatever you expect it to display you can assume its correct .

[jwxie]

Code: Select all

$result = $db->sql_query($sql);
$db->sql_freeresult($result);

just a minor question
sometime i don't see sql_freeresult in other parts of the phpbb files

[Erik Frèrejean]

The $db->sql_freeresult($result); is used always. I think that you are tricked by the fact that it isn't always called right after the query, sometimes this isn't possible as you might want to re-use the result later on or just don't want to worry about it.
Due to the way phpBB is setup you can (but shouldn't) leave the call out at all as long you call the garbage_collection() function somewhere (this is done in page_footer()) as this function calls the $db->sql_close() method. This method will run $db->sql_freeresult($result) on all open queries before it closes the database connection.
Good coding practices however makes you to call it yourself.

[jwxie]

The $db->sql_freeresult($result); is used always. I think that you are tricked by the fact that it isn't always called right after the query, sometimes this isn't possible as you might want to re-use the result later on or just don't want to worry about it.
Due to the way phpBB is setup you can (but shouldn't) leave the call out at all as long you call the garbage_collection() function somewhere (this is done in page_footer()) as this function calls the $db->sql_close() method. This method will run $db->sql_freeresult($result) on all open queries before it closes the database connection.
Good coding practices however makes you to call it yourself.

Erik, thanks a lot
now i understood.
yes i was reading phpbb files,. and i didn't notice that in fact
i was tricked by it, thanks again bro