[RC] Auto Groups MOD 0.2.2

[taiwai]

Aha! There it is. This was the only thing keeping me from updating. SWEET!

are you going to make it make the new group the default group? or have an option for it?

[A_Jelly_Doughnut]

That will be an option in 0.0.3.

[A_Jelly_Doughnut]

0.0.3 is uploaded. See first post for download.

[taiwai]

nice.. v3 is awesome

[A_Jelly_Doughnut]

I think I can make this more efficient by allowing $mode to be an array and making a more complex query using the OR clause...would definitely cut query count, but might actually be slower. Will try

[taiwai]

hmm at the moment it isn't making the group default for users..
I noticed that it isn't saving the option when I check the 'make group default' checkbox - when I next go back to the group settings it will be unchecked, so this is probably the reason. any idea how I can fix it?

also I was wondering if there was a way you can make it skip adding to the 'admin log'? it kinda fills it up

One last question.. when does it check to see if users are added to the correct group? is it just after they post? because if I add a usergroup which needs between 0 and 150 posts will that make it so all newly registered users are auto-added to that group?

oh and I have a feature suggestion for a future version.. I was thinking it would be good if you could make a auto-group resync feature which will go through the entire database and make sure all the users are in the correct groups. (just in case things get out of sync or if the admin wants to change the post limit or warning limit and wants all users to be updated)

thanks

[A_Jelly_Doughnut]

It checks post count after posting, and on login. Full resync is a good idea.

I'll look into the error of not storing the checkbox.

And that is the purpose of the admin log...whether it fills it or not.

[A_Jelly_Doughnut]

It looks to me like the default checkbox is working as intended. Can you be more specific?

[taiwai]

Hmm I still haven't managed to get the checkbox working...
It could be to do with something which went a little wrong when I was installing it:

Code: Select all

#
#----[ OPEN ]---------------------
#
/includes/acp/acp_groups.php

#
#----[ FIND ]---------------------
#
                  'founder_manage'   => 0,

#
#---[ AFTER, ADD ]----------------
#
                  // auto groups mod
                  'min_days'      => request_var('min_group_days', 0),
                  'max_days'      => request_var('max_group_days', 0),
                  'min_warnings'   => request_var('min_group_warnings', 0),
                  'max_warnings'   => request_var('max_group_warnings', 0),
                  'min_posts'      => request_var('min_group_posts', 0),
                  'max_posts'      => request_var('max_group_posts', 0),
                  'auto_default'   => request_var('group_auto_default', 0);


I couldn't find this line, the closest I could find to it was this: (10th line down)

Code: Select all

               $submit_ary = array(
                  'colour'         => request_var('group_colour', ''),
                  'rank'            => request_var('group_rank', 0),
                  'receive_pm'      => isset($_REQUEST['group_receive_pm']) ? 1 : 0,
                  'legend'         => isset($_REQUEST['group_legend']) ? 1 : 0,
                  'message_limit'      => request_var('group_message_limit', 0),
               );

               if ($user->data['user_type'] == USER_FOUNDER)
               {
                  $submit_ary['founder_manage'] = isset($_REQUEST['group_founder_manage']) ? 1 : 0;
               }
               else
               {
                  $submit_ary['founder_manage'] = 0;
               }


so I made it look like this:

Code: Select all

               $submit_ary = array(
                  'colour'         => request_var('group_colour', ''),
                  'rank'            => request_var('group_rank', 0),
                  'receive_pm'      => isset($_REQUEST['group_receive_pm']) ? 1 : 0,
                  'legend'         => isset($_REQUEST['group_legend']) ? 1 : 0,
                  'message_limit'      => request_var('group_message_limit', 0),
                  // auto groups mod
                  'min_days'      => request_var('min_group_days', 0),
                  'max_days'      => request_var('max_group_days', 0),
                  'min_warnings'   => request_var('min_group_warnings', 0),
                  'max_warnings'   => request_var('max_group_warnings', 0),
                  'min_posts'      => request_var('min_group_posts', 0),
                  'max_posts'      => request_var('max_group_posts', 0),
                  'auto_default'   => request_var('group_auto_default', 0),
               );

               if ($user->data['user_type'] == USER_FOUNDER)
               {
                  $submit_ary['founder_manage'] = isset($_REQUEST['group_founder_manage']) ? 1 : 0;
               }
               else
               {
                  $submit_ary['founder_manage'] = 0;
               }


do you think that could be the reason it's not working?

[A_Jelly_Doughnut]

No, that probably isn't the error...that looks perfectly valid

Try changing

Code: Select all

'auto_default'   => request_var('group_auto_default', 0),

to

Code: Select all

'auto_default'    => isset($_POST['group_auto_default']),

and let me know what happens.